This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] readelf support for DW_END_default, DW_END_big, DW_END_little


Hi Peeter,

> + * binutils/dwarf.c (read_and_display_attr_value): Handle
> + DW_AT_endianity, DW_END_default, DW_END_big, DW_END_little

Thanks for submitting this patch.  There was a small problem in that
the code did not handle user specified endian values (ie in the range
0x40 - 0xff).

Whilst looking into this, I also noticed that there are some more DWARF
attributes whose values we do not decode (eg DW_AT_decimal_sign and
DW_AT_defaulted).  Plus there was no testcase for the encoding and 
decoding of these attributes.  So I have taken the liberty of extending
your patch to include these features and checked it in.

Cheers
  Nick

binutils/ChangeLog
2017-10-11  Peeter Joot  <peeter.joot@lzlabs.com>
	Nick Clifton  <nickc@redhat.com>

	* dwarf.c (read_and_display_attr_value): Handle DW_AT_endianity,
	DW_END_default, DW_END_big, DW_END_little, DW_ATE_UCS,
	DW_ATE_ASCII, DW_CC_pass_by_reference, DW_CC_pass_by_value,
	DW_CC_GNU_renesas_sh, DW_CC_GNU_borland_fastcall_i386,
	DW_AT_decimal_sign, DW_AT_defaulted, DW_AT_discr_list.
	(get_TAG_name): Report user generated tag values.
	* testsuite/binutils-all/dwarf-attributes.S: New test.
	* testsuite/binutils-all/dwarf-attributes.W. Expected output from
	readelf.
	* testsuite/binutils-all/readelf.exp: Run the new test.

Attachment: fred
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]