This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFC] .fill does not accept forward labels
On Mon, Oct 16, 2017 at 11:46:41AM +0100, Maciej W. Rozycki wrote:
> On Mon, 16 Oct 2017, Andreas Krebbel wrote:
>
> > > Your updated patch seems to have been garbled in transit; I have fixed
> > > the breakage however and applied it regardless, and gave it a quick shot.
> >
> > Next try then:
>
> OK, that's what I came up with too.
>
> > > It revealed failures for these targets:
> > >
> > > hppa-hp-hpux10 +FAIL: fill test with forward labels
> > > hppa64-hp-hpux11.23 +FAIL: fill test with forward labels
> > > ia64-vms +FAIL: fill test with forward labels
> > > sh-pe +FAIL: fill test with forward labels
> > > tic4x-coff +FAIL: fill test with forward labels
> > > tic54x-coff +FAIL: fill test with forward labels
With that one the first 4 fails go away. The last two occur also with .skip.
new file mode 100644
index 0000000..a9ee853
--- /dev/null
+++ b/gas/testsuite/gas/all/fill-1.d
@@ -0,0 +1,8 @@
+#objdump: -s -j .data -j "\$DATA\$"
+#name: fill test with forward labels
+
+.*: +file format .*
+
+Contents of section (\.data|\$DATA\$):
+ [^ ]* 0a0a0d0d 0b0b0c0c .*
+
diff --git a/gas/testsuite/gas/all/fill-1.s b/gas/testsuite/gas/all/fill-1.s
index e72cbf1..34c52cc 100644
--- a/gas/testsuite/gas/all/fill-1.s
+++ b/gas/testsuite/gas/all/fill-1.s
@@ -1,5 +1,7 @@
- .text
- .fill (2f-1f), 1, 0x90
-1:
- .word 42
-2:
+ .data
+ .dc.w 0x0a0a
+ .fill (.L2-.L1), 1, 0x0d
+.L1:
+ .dc.w 0x0b0b
+.L2:
+ .dc.w 0x0c0c
diff --git a/gas/testsuite/gas/all/gas.exp b/gas/testsuite/gas/all/gas.exp
index 93e31da..1810ef4 100644
--- a/gas/testsuite/gas/all/gas.exp
+++ b/gas/testsuite/gas/all/gas.exp
@@ -487,4 +487,4 @@ run_dump_test "org-4"
run_dump_test "org-5"
run_dump_test "org-6"
-gas_test "fill-1.s" "" "" "test .fill forward label references"
+run_dump_test "fill-1"