Re: [PATCH] PR ld/17618: Check PC-relative offset overflow in PLT entry

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Sat, Oct 21, 2017 at 1:47 PM, Hans-Peter Nilsson
<hans-peter.nilsson@axis.com> wrote:
>> From: "H.J. Lu" <hjl.tools@gmail.com>
>> Date: Sat, 21 Oct 2017 12:17:23 -0700
>
>> On Sat, Oct 21, 2017 at 11:34 AM, Hans-Peter Nilsson
>> <hans-peter.nilsson@axis.com> wrote:
>> >> From: "H.J. Lu" <hjl.tools@gmail.com>
>> >> Date: Wed, 9 Aug 2017 15:08:54 -0700
>> >> +# Set LD_CLASS to "64bit" for 64-bit LD.
>> >> +if { ![info exists LD_CLASS] } then {
>> >> +    set readelf_output [run_host_cmd "$READELF" "-h $LD"]
>
> (s/LD/REAL_LD/)
>
>> It checks if linker can support 64-bit address space,
>
> No, as it stands it tests that the linker *is of* 64-bit
> address-space, not that it *generates* 64-bit address-space, for

That is exactly what it is testing.  We can tell the target address
from target.   But here is we want to know if the linker running on
host/build machine is 64-bit.

> other than a native linker.  Again, you need to test an object
> other than $REAL_LD.
>
>> which
>> is independent of bfd-size.   Some tests require that linker
>> supports 64-bit address.
>
> It's good that we agree about these parts.
>
> brgds, H-P
>



-- 
H.J.