This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] RISC-V: Fix disassembly of c.addi4spn, c.addi16sp, c.lui when imm=0


On Tue, 24 Oct 2017 09:42:23 PDT (-0700), Nick Clifton wrote:
> Hi Palmer,
>
>> opcodes/ChangeLog
>>
>> 2017-10-20  Andrew Waterman  <andrew@sifive.com>
>>
>>         * riscv-opc.c (match_c_addi16sp) : New function.
>>         (match_c_addi4spn): New function.
>>         (match_c_lui): Don't allow 0-immediate encodings.
>>         (riscv_opcodes) <addi>: Use the above functions.
>>         <add>: Likewise.
>>         <c.addi4spn>: Likewise.
>>         <c.addi16sp>: Likewise.
>>
>> gas/ChangeLog
>>
>> 2017-10-24  Andrew Waterman  <andrew@sifive.com>
>>
>>         * gas/testsuite/gas/riscv/c-addi16sp-fail.d: New test.
>>         gas/testsuite/gas/riscv/c-addi16sp-fail.l: Likewise.
>>         gas/testsuite/gas/riscv/c-addi16sp-fail.s: Likewise.
>>         gas/testsuite/gas/riscv/c-addi4spn-fail.d: Likewise.
>>         gas/testsuite/gas/riscv/c-addi4spn-fail.l: Likewise.
>>         gas/testsuite/gas/riscv/c-addi4spn-fail.s: Likewise.
>>         testsuite/gas/riscv/riscv.exp: Add new tests.
>
> Approved - please apply - except that the gas ChangeLog entry
> does need the "gas/" prefix to the filenames...

Committed.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]