This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] BFD: Write Linux core PRSTATUS note into MIPS core file


On Wed, 25 Oct 2017, Djordje Todorovic wrote:

> diff --git a/bfd/elf32-mips.c b/bfd/elf32-mips.c
> index 17ca432..69c6061 100644
> --- a/bfd/elf32-mips.c
> +++ b/bfd/elf32-mips.c
> @@ -2554,6 +2593,9 @@ static const struct ecoff_debug_swap mips_elf32_ecoff_debug_swap = {
>  #define ELF_COMMONPAGESIZE		0x1000
>  #define elf32_bed			elf32_tradbed
>  
> +#undef elf_backend_write_core_note
> +#define elf_backend_write_core_note		elf32_mips_write_core_note

 This is column #48 rather than #40 (compare the `elf32_bed' definition 
above and the preceding ones).  Likewise the two other places.  I'll fix 
it up myself when committing though, no need to resubmit.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]