This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH][GAS][ARM] Add Dot Product Extension as mandatory feature on Armv8.4-A [Patch (2/3)]
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: "nickc at redhat dot com" <nickc at redhat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "Ramana Radhakrishnan" <Ramana dot Radhakrishnan at arm dot com>
- Date: Wed, 8 Nov 2017 13:56:51 +0000
- Subject: RE: [PATCH][GAS][ARM] Add Dot Product Extension as mandatory feature on Armv8.4-A [Patch (2/3)]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tamar dot Christina at arm dot com;
- Nodisclaimer: True
- References: <20171108100825.GA19153@arm.com> <63e91d37-420c-de88-e83a-608a5821fa78@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Hi Nick,
> >
> > * config/tc-arm.c (arm_extensions):
> > Add FPU_ARCH_DOTPROD_NEON_VFP_ARMV8.
> > * testsuite/gas/arm/dotprod-mandatory.d: New test.
>
> Applied. Note - I dropped this frag from the patch:
>
> +static const arm_feature_set arm_ext_v8_4 =
> + ARM_FEATURE_CORE_HIGH (ARM_EXT2_V8_4A);
Thanks, I was trying to recreate the problem before I responded.
The value isn't really needed for ARM.
But I did find why I didn't catch it, my test
Scripts were essentially still cross compiling. So the error didn't show up.
I'll fix them so this'll be caught next time.
Thanks,
Tamar
>
> If it really is needed then please submit a follow up patch.
>
> Cheers
> Nick