This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][GAS][AArch64] Add new fields and operands required for Armv8.4-a [Patch (1/6)]


Hi Tamar,

  I am very sorry, but I have mucked up.  Twice...

Firstly:

>> This patch adds the new Fields and Operand types for the new
>> instructions in Armv8.4-a.

It was not this patch that triggered the build problem.  It was the 
patch for "Retroactively split CRYPTO into AES and SHA2.Q":

  https://www.sourceware.org/ml/binutils/2017-11/msg00068.html

Secondly, I committed the patch in that email, even though it did
break 32-bit builds.  Doh.  (I should have stayed in bed yesterday).

So - I have checked in a supplemental patch to change the underlying 
type of the aarch64_feature_set typedef, which I think is what you wanted.

Also, the patch for the "Add new fields and operands required for Armv8.4-a [Patch (1/6)]"
submission is approved - so please could it be applied.

Cheers
  Nick

include/ChangeLog
2017-11-09  Nick Clifton  <nickc@redhat.com>

	* opcode/aarch64.h (aarch64_feature_set): Change type to unsigned
	long long.

diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
index 325b757b1c..a597ebe0cb 100644
--- a/include/opcode/aarch64.h
+++ b/include/opcode/aarch64.h
@@ -82,7 +82,7 @@ typedef uint32_t aarch64_insn;
 #define AARCH64_ANY		AARCH64_FEATURE (-1, 0)	/* Any basic core.  */
 
 /* CPU-specific features.  */
-typedef unsigned long aarch64_feature_set;
+typedef unsigned long long aarch64_feature_set;
 
 #define AARCH64_CPU_HAS_ALL_FEATURES(CPU,FEAT)	\
   ((~(CPU) & (FEAT)) == 0)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]