This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: First-time binutils repository code-stare - indentation and contribution process
- From: "Maciej W. Rozycki" <macro at mips dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: "Francois H. Theron" <francois dot theron at netronome dot com>, <binutils at sourceware dot org>
- Date: Mon, 13 Nov 2017 10:45:19 +0000
- Subject: Re: First-time binutils repository code-stare - indentation and contribution process
- Authentication-results: sourceware.org; auth=none
- References: <CACv6nk=wbtgFL8AhMYgjSWRyg-geMLeD+6wz3On-UzF__FH=3w@mail.gmail.com> <07c3d7e7-11e0-b0c2-641f-943ca7a2d3db@redhat.com>
On Thu, 9 Nov 2017, Nick Clifton wrote:
> > In readelf.c I see some inconsistent mixed use of real tabs and spaces
> > on the same line. I assume the normal convention applies where you
> > leave existing invalid whitespace alone, but use the correct style for
> > new code?
>
> Actually the old code ought to be corrected as well. Although it is better
> to do so as a separate set of patches, rather than including such changes
> along with new code.
Fixing formatting issues alone however has the drawback of obfuscating
`git blame' output, so it may be good to weigh on a case by case basis
whether it is worth it.
FWIW,
Maciej