This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] x86: use correct register names

On Tue, Nov 14, 2017 at 5:36 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 14.11.17 at 13:33, <hjl.tools@gmail.com> wrote:
>> On Mon, Nov 13, 2017 at 11:31 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>> A test for this is going to be introduced in the next patch of this
>>> series.
>
> Did you read the above ...
>
>> Please use .byte directive to add 3 testcases for each case to verify
>> that disassembler
>> properly ignores this bit.   OK with that change.
>
> ... before replying?

Please make each patch self-contained by including relevant tests in
each patch.

Thanks.

-- 
H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]