This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86: fix AVX-512 16-bit addressing


>>> On 22.11.17 at 13:39, <hjl.tools@gmail.com> wrote:
> On Wed, Nov 22, 2017 at 12:06 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 21.11.17 at 20:06, <hjl.tools@gmail.com> wrote:
>>> On Mon, Nov 20, 2017 at 7:15 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> Despite EVEX encodings not being available in real and VM86 modes,
>>>> 16-bit addressing still needs to be handled properly for 16-bit
>>>> protected mode as well as 16-bit addressing in 32-bit mode. Neither
>>>> should displacements be dropped silently by the assembler, nor should
>>>> the disassembler fail to correctly scale 8-bit displacements.
>>>> ---
>>>> I additionally doubt the other CODE_16BIT check (the conditional of
>>>> which is visible in patch context here) is correct either; I can't even
>>>> figure a way of how this conditional would be reachable in the first
>>>> place. Hence I wonder whether that code can be removed altogether.
>>>
>>>
>>>> gas/
>>
>> Did you mean to reply to that remark, but then forgot?
> 
> I did a few lines after this.

If you mean ...

> Do we really support 32-bit displacement in 16-bit mode or with 0x67
> address prefix?

... this, then yes, I notice that I failed to reply to that part (will do
in a minute), but this certainly doesn't relate to the remark after
the --- separator (still visible above).

Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]