This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Riscv ld-elf/stab failure, and fake label cleanup.
- From: Nick Clifton <nickc at redhat dot com>
- To: Jim Wilson <jimw at sifive dot com>, binutils at sourceware dot org
- Date: Wed, 22 Nov 2017 17:11:43 +0000
- Subject: Re: [PATCH] Riscv ld-elf/stab failure, and fake label cleanup.
- Authentication-results: sourceware.org; auth=none
- References: <20171120224104.12561-1-jimw@sifive.com>
Hi Jim,
> Comments?
I think you may also need to update bfd/elf.c:_bfd_elf_is_local_label_name()
Although I am not quite sure how you would do this. Maybe adding another field
to the elf_backend_data structure ?
> gas/
> * as.c: Include write.h.
> (common_emul_init): Use FAKE_LABEL_NAME.
> * ecoff.c (add_file, ecoff_directive_end, ecoff_directive_loc):
> Likewise.
> (ecoff_build_symbols): Use FAKE_LABEL_CHAR.
> * expr.c (get_symbol_name): Use FAKE_LABEL_CHAR. Accept only if
> input_from_string is TRUE.
> * read.c (input_from_string): New.
> (read_symbol_name): Use FAKE_LABEL_CHAR. Accept only if
> input_from_string is TRUE.
> (temp_ilp): Set input_from_string to TRUE.
> (restore_ilp): Set input_from_string to FALSE.
> * read.h (input_from_string): Declare.
> * symbols.c: Include write.h
> (S_IS_LOCAL): Check for FAKE_LABEL_CHAR.
> (symbol_relc_make_sym): Fix comment refering to default fake label
> string.
> * write.h (FAKE_LABEL_CHAR): New.
> * config/tc-riscv.h (FAKE_LABEL_CHAR): Define.
> * testsuite/gas/all/err-fakelabel.s: New.
Approved - please apply.
Cheers
Nick