This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix build error with --enable-targets=all.

From: Jim Wilson <jimw at sifive dot com>
To: binutils at sourceware dot org
Cc: Jim Wilson <jimw at sifive dot com>
Date: Thu, 23 Nov 2017 12:36:16 -0800
Subject: Re: [PATCH] Fix build error with --enable-targets=all.
Authentication-results: sourceware.org; auth=none
References: <20171123022319.GM10905@bubble.grove.modra.org> <20171123031516.31949-1-jimw@sifive.com>

On Wed, Nov 22, 2017 at 7:15 PM, Jim Wilson <jimw@sifive.com> wrote:

> It only fails with --enable-targets=all, which is something I didn't think
> to
> check.  I can fix it with the following patch.  This assumes we won't add
> anything else to as.c that uses FAKE_LABEL_NAME, so we can just disable the
> setting in obj-multi.h for this file.  I can't think of anything more
> elegant
> at the moment.
>
>         gas/
>         * as.c (INITIALIZING_EMULS): Define.
>         * config/obj-multi.h (FAKE_LABEL_NAME): When INITIALIZING_EMULS
> set,
>         don't define it.
>

Committed.  So that enable-targets=all builds work again.  If you don't
like this patch, we can revise it later.

Jim

References:
- Re: [PATCH] Riscv ld-elf/stab failure, and fake label cleanup.
  - From: Alan Modra
- [PATCH] Fix build error with --enable-targets=all.
  - From: Jim Wilson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]