This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] elf: Properly compute offsets of desc and next note
- From: Nick Clifton <nickc at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, binutils at sourceware dot org
- Date: Fri, 24 Nov 2017 10:19:19 +0000
- Subject: Re: [PATCH] elf: Properly compute offsets of desc and next note
- Authentication-results: sourceware.org; auth=none
- References: <20171116115641.GA23551@gmail.com>
Hi H.J.
> bfd/
>
> PR binutils/22444
> * elf.c (elf_read_notes): Add an argument for note aligment.
> (elf_parse_notes): Likewise.
> (_bfd_elf_make_section_from_shdr): Pass section aligment to
> elf_parse_notes.
> (bfd_section_from_phdr): Pass segment aligment to elf_read_notes.
> (elf_parse_notes): Add an argument for note aligment. Use
> ELF_NOTE_DESC_OFFSET to get the offset of the note descriptor.
> Use ELF_NOTE_NEXT_OFFSET to get the offset of the next note
> entry.
> (elf_read_notes): Add an argument for note aligment and pass it
> to elf_parse_notes.
>
> binutils/
>
> PR binutils/22444
> * readelf.c (process_notes_at): Use ELF_NOTE_DESC_OFFSET to get
> the offset of the note descriptor. Use ELF_NOTE_NEXT_OFFSET to
> get the offset of the next note entry.
>
> include/
>
> PR binutils/22444
> * elf/external.h (ELF_ALIGN_UP): New.
> (ELF_NOTE_DESC_OFFSET): Likewise.
> (ELF_NOTE_NEXT_OFFSET): Likewise.
Patch approved - please apply.
Thank you for your patience in this matter. I wanted to give other
contributors a chance to comment on the patch, but none have been
forthcoming and I have no objections to it myself.
Cheers
Nick