This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 2/8] gas: xtensa: extract jump assembling for trampolines
- From: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>
- Cc: binutils at sourceware dot org, "linux-xtensa at linux-xtensa dot org" <linux-xtensa at linux-xtensa dot org>
- Date: Mon, 27 Nov 2017 14:06:50 -0800
- Subject: Re: [PATCH 2/8] gas: xtensa: extract jump assembling for trampolines
- Authentication-results: sourceware.org; auth=none
- References: <1511811574-11128-1-git-send-email-jcmvbkbc@gmail.com> <1511811574-11128-3-git-send-email-jcmvbkbc@gmail.com>
On Mon, Nov 27, 2017 at 11:39 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> init_trampoline_frag, add_jump_to_trampoline and xg_relax_trampoline add
> a jump to the end of a trampoline frag. Extract it into a separate
> funciton and use it in all these places. No functional changes.
>
> gas/
> 2017-11-20 Max Filippov <jcmvbkbc@gmail.com>
>
> * config/tc-xtensa.c (xg_append_jump): New function.
> (xg_relax_trampoline, init_trampoline_frag)
> (add_jump_to_trampoline): Replace trampoline jump assembling
> code with a call to xg_append_jump.
I'm not in a good position to test these, but they do seem fine.
I'm a little disappointed the j.l pseudo op never got traction, but oh well.