This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/8] gas: xtensa: reuse trampoline placement code


On Mon, Nov 27, 2017 at 11:39 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> There's almost exact copy of the trampoline placement code in the
> search_trampolines function that is used for jumps generated for relaxed
> branch instructions. Get rid of the duplication and reuse
> xg_find_best_trampoline function for that.
>
> gas/
> 2017-11-20  Max Filippov  <jcmvbkbc@gmail.com>
>
>         * config/tc-xtensa.c (search_trampolines, get_best_trampoline):
>         Remove definitions.
>         (xg_find_best_trampoline_for_tinsn): New function.
>         (relax_frag_immed): Replace call to get_best_trampoline with a
>         call to xg_find_best_trampoline_for_tinsn.
>         * testsuite/gas/xtensa/trampoline.d: Adjust absolute addresses
>         as the placement of trampolines for relaxed branches has been
>         changed.
> ---
>  gas/config/tc-xtensa.c                | 97 ++++-------------------------------
>  gas/testsuite/gas/xtensa/trampoline.d |  6 +--
>  2 files changed, 12 insertions(+), 91 deletions(-)

This is OK.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]