This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 6/8] gas: xtensa: reuse trampoline placement code
- From: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>
- Cc: binutils at sourceware dot org, "linux-xtensa at linux-xtensa dot org" <linux-xtensa at linux-xtensa dot org>
- Date: Mon, 27 Nov 2017 14:10:09 -0800
- Subject: Re: [PATCH 6/8] gas: xtensa: reuse trampoline placement code
- Authentication-results: sourceware.org; auth=none
- References: <1511811574-11128-1-git-send-email-jcmvbkbc@gmail.com> <1511811574-11128-7-git-send-email-jcmvbkbc@gmail.com>
On Mon, Nov 27, 2017 at 11:39 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> There's almost exact copy of the trampoline placement code in the
> search_trampolines function that is used for jumps generated for relaxed
> branch instructions. Get rid of the duplication and reuse
> xg_find_best_trampoline function for that.
>
> gas/
> 2017-11-20 Max Filippov <jcmvbkbc@gmail.com>
>
> * config/tc-xtensa.c (search_trampolines, get_best_trampoline):
> Remove definitions.
> (xg_find_best_trampoline_for_tinsn): New function.
> (relax_frag_immed): Replace call to get_best_trampoline with a
> call to xg_find_best_trampoline_for_tinsn.
> * testsuite/gas/xtensa/trampoline.d: Adjust absolute addresses
> as the placement of trampolines for relaxed branches has been
> changed.
> ---
> gas/config/tc-xtensa.c | 97 ++++-------------------------------
> gas/testsuite/gas/xtensa/trampoline.d | 6 +--
> 2 files changed, 12 insertions(+), 91 deletions(-)
This is OK.