This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [GAS][AARCH64]Fix a typo for IP1 register alias.


On 29/11/17 11:00, Renlin Li wrote:
> Hi all,
> 
> This should be an obvious fix.
> It corrects the register number for IP1 to 17.
> 
> Regards,
> Renlin
> 
> gas/ChangeLog:
> 
> 2017-11-29  Renlin Li  <renlin.li@arm.com>
> 
>     * config/tc-aarch64.c (reg_names): Fix IP1 register alias error.
>     * testsuite/gas/aarch64/register_aliases.s: Add IP0 and IP1 tests.
>     * testsuite/gas/aarch64/register_aliases.d: Update.
> 
> 

OK.

R.

> tmp.diff
> 
> 
> diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
> index 4ae0624..832f4e8 100644
> --- a/gas/config/tc-aarch64.c
> +++ b/gas/config/tc-aarch64.c
> @@ -6804,7 +6804,7 @@ static const reg_entry reg_names[] = {
>    REGSET31 (w, R_32), REGSET31 (W, R_32),
>  
>    REGDEF_ALIAS (ip0, 16, R_64), REGDEF_ALIAS (IP0, 16, R_64),
> -  REGDEF_ALIAS (ip1, 17, R_64), REGDEF_ALIAS (IP1, 16, R_64),
> +  REGDEF_ALIAS (ip1, 17, R_64), REGDEF_ALIAS (IP1, 17, R_64),
>    REGDEF_ALIAS (fp, 29, R_64), REGDEF_ALIAS (FP, 29, R_64),
>    REGDEF_ALIAS (lr, 30, R_64), REGDEF_ALIAS (LR, 30, R_64),
>    REGDEF (wsp, 31, SP_32), REGDEF (WSP, 31, SP_32),
> diff --git a/gas/testsuite/gas/aarch64/register_aliases.d b/gas/testsuite/gas/aarch64/register_aliases.d
> index 677d5f0..eab6387 100644
> --- a/gas/testsuite/gas/aarch64/register_aliases.d
> +++ b/gas/testsuite/gas/aarch64/register_aliases.d
> @@ -7,4 +7,6 @@ Disassembly of section \.text:
>  0+ <.*>:
>     0:	8b1e0210 	add	x16, x16, x30
>     4:	f90003b0 	str	x16, \[x29\]
> -   8:	f94003b1 	ldr	x17, \[x29\]
> \ No newline at end of file
> +   8:	f94003b1 	ldr	x17, \[x29\]
> +   c:	f90003b0 	str	x16, \[x29\]
> +  10:	f94003b1 	ldr	x17, \[x29\]
> diff --git a/gas/testsuite/gas/aarch64/register_aliases.s b/gas/testsuite/gas/aarch64/register_aliases.s
> index 5864283..fcd0650 100644
> --- a/gas/testsuite/gas/aarch64/register_aliases.s
> +++ b/gas/testsuite/gas/aarch64/register_aliases.s
> @@ -6,4 +6,6 @@
>  	add	ip0, ip0, lr
>  	str 	ip0, [fp]
>  	ldr	ip1, [fp]
> +	str 	IP0, [fp]
> +	ldr	IP1, [fp]
>  
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]