This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][GOLD] Fix PR22233 gold segfault in relocate_erratum_stub on aarch64-linux-gnu
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Peter Smith <peter dot smith at linaro dot org>
- Cc: Binutils <binutils at sourceware dot org>, Han Shen <shenhan at google dot com>
- Date: Thu, 30 Nov 2017 13:56:35 -0800
- Subject: Re: [PATCH][GOLD] Fix PR22233 gold segfault in relocate_erratum_stub on aarch64-linux-gnu
- Authentication-results: sourceware.org; auth=none
- References: <CAEt-8LD2expg_e1Qt0xnZEoOk6317VAD0tWQ3ONFkLugksJD_Q@mail.gmail.com> <5b5fc6b0-7087-a9d7-a33e-9fb6e1f4f346@ubuntu.com> <CAEt-8LDQefmYgs=LwLVKvwcvzEpaBMUnCMTwgKq88D1tWtGX1Q@mail.gmail.com>
> General ping for this patch. The fix is one line, and together with
> the fixes for PR20765 should fix the known problems with the
> --fix-cortex-a53-843419 option.
This is OK, but I prefer it without the + and - of view_offset.
>> This is a first time posting a fix to this mailing list so my
>> apologies for missing anything out.
No problems -- you're just missing a ChangeLog entry. I've committed
the modified patch with the following ChangeLog:
2017-11-30 Peter Smith <peter.smith@linaro.org>
gold/
PR gold/22233
* aarch64.cc (AArch64_relobj::fix_errata_and_relocate_erratum_stubs):
Fix calculation of stub address.
Thanks for the fix!
-cary