This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix internal error on unterminated --start-lib option.
- From: Benjamin Peterson <bp at benjamin dot pe>
- To: Cary Coutant <ccoutant at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Fri, 01 Dec 2017 13:46:37 -0800
- Subject: Re: [PATCH] Fix internal error on unterminated --start-lib option.
- Authentication-results: sourceware.org; auth=none
- References: <20170902180418.22872-1-bp@benjamin.pe> <CAJimCsErZsnmggSb1mb4NkX4cQ8frkkbw7svj5oD9rRY8cv78w@mail.gmail.com>
On Fri, Dec 1, 2017, at 13:04, Cary Coutant wrote:
> > * Makefile.in: Regenerate.
>
> No need to regenerate this -- automake keeps generating this useless
> diff.
Ah, that's unfortunate.
>
> > * gold.cc (queue_initial_tasks) Check for number of real input files.
> > * options.cc (Command_line::process) Check for unterminated --start-lib
> > options.
> > * testsuite/Makefile.am: Add new test script.
> > * testsuite/Makefile.in: Regenerate.
> > * testsuite/check_empty_command_lines.sh: New test script.
>
> This is OK. I've committed the patch (without Makefile.in) on your
> behalf.
Thank you!
While I have you, can I ask how the gold maintainers run the test suite?
Running x86_64, I noticed that several tests are broken on master. The
incremental linking ones look like legitimate failures.