This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch Arm] Add CSDB instruction
- From: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: binutils <binutils at sourceware dot org>
- Date: Tue, 9 Jan 2018 15:29:24 +0000
- Subject: Re: [Patch Arm] Add CSDB instruction
- Authentication-results: sourceware.org; auth=none
- References: <63f3285c-861a-f75e-fe25-b108a076ce04@foss.arm.com> <CAKdteObhDm_Z3spNALEu=aGcQveWGD2ffFY1eOhNtOkxmTzjyg@mail.gmail.com>
On 1/9/18 3:21 PM, Christophe Lyon wrote:
> On 9 January 2018 at 15:31, Ramana Radhakrishnan
> <ramana.radhakrishnan@foss.arm.com> wrote:
>> Hi,
>>
>> I'm applying this patch for James Greenhalgh to add the CSDB
>> instruction to the Arm backend. Regression tested on arm-none-eabi with
>> no regressions. Applied to trunk.
>>
>
> Hi Ramana/James,
>
> The new test fails on arm*pe targets, I didn't check why.
Sigh, I suspect it's because mapping symbols don't work on PE targets.
I'll take a look.
regards
Ramana
>
> Christophe
>
>> Thanks,
>> Ramana
>> --------
>>
>>
>> CSDB is a new instruction which Arm has defined. As it shares the
>> encoding space with NOP instructions, it is available from Armv3 in Arm
>> mode, and Armv6T2 in Thumb mode.
>>
>> OK? If so, please commit on my behalf as I don't have commit rights over
>> here.
>>
>> Thanks,
>> James
>>
>> ---
>> opcodes/
>>
>> 2018-01-09 James Greenhalgh <james.greenhalgh@arm.com>
>>
>> * arm-dis.c (arm_opcodes): Add csdb.
>> (thumb32_opcodes): Add csdb.
>>
>> gas/
>>
>> 2018-01-09 James Greenhalgh <james.greenhalgh@arm.com>
>>
>> * config/tc-arm.c (insns): Add csdb, enable for Armv3 and above
>> in Arm execution state, and Armv6T2 and above in Thumb execution
>> state.
>> * testsuite/gas/arm/csdb.s: New.
>> * testsuite/gas/arm/csdb.d: New.
>> * testsuite/gas/arm/thumb2_it_bad.l: Add csdb.
>> * testsuite/gas/arm/thumb2_it_bad.s: Add csdb.