This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH] [MIPS] Add fix for loongson3 llsc errata
- From: Matthew Fortune <Matthew dot Fortune at mips dot com>
- To: Jiaxun Yang <jiaxun dot yang at flygoat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 22 Jan 2018 08:51:25 +0000
- Subject: RE: [PATCH] [MIPS] Add fix for loongson3 llsc errata
- Authentication-results: sourceware.org; auth=none
- References: <20180121171754.16813-1-jiaxun.yang@flygoat.com>
Jiaxun Yang <jiaxun.yang@flygoat.com> writes:
> +/* ...likewise -mfix-loongson3-llsc. */
> + static bfd_boolean mips_fix_loongson3_llsc = TRUE;
> +
Just a brief comment... you are asking here for all code generation
for all cores to pay the penalty of the loongson errata by enabling
this by default.
You will probably need to enable it (if not explicitly disabled)
for just the loongson cores when targeted with -march. If you are
aiming for this to be enabled in a linux distro such as debian or
fedora so that all base packages are safe then you may need a
configure time option to enable this by default (if the distro
maintainer chooses to do so).
I have not looked at the implementation just noticed the default
effect being undesirable.
Hope that makes sense.
Thanks,
Matthew