This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[committed] MIPS/GAS: Correct default ABI selection for `mips64*-ps2-elf*'
- From: "Maciej W. Rozycki" <macro at mips dot com>
- To: Nick Clifton <nickc at redhat dot com>, <binutils at sourceware dot org>
- Date: Tue, 23 Jan 2018 21:21:43 +0000
- Subject: [committed] MIPS/GAS: Correct default ABI selection for `mips64*-ps2-elf*'
- Authentication-results: sourceware.org; auth=none
Correct an issue with the `mips64*-ps2-elf*' target introduced with
commit e407c74b5b60 ("Support for MIPS R5900 (Sony Playstation 2)"),
<https://sourceware.org/ml/binutils/2012-12/msg00240.html> and make
the n32 ABI the default for GAS, consistently with how BFD and LD
are configured for this target.
gas/
* configure.ac: Also set `mips_default_abi' to N32_ABI for
`mips64*-ps2-elf*'.
* configure: Regenerate.
---
Hi,
This removes 197 LD test suite failures for `mips64el-ps2-elf'; obviously
nobody has ever run it. Committed.
Nick: OK for 2.30?
Maciej
---
gas/configure | 3 ++-
gas/configure.ac | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
binutils-mips-gas-config-ps2.diff
Index: binutils/gas/configure
===================================================================
--- binutils.orig/gas/configure 2018-01-19 18:37:43.000000000 +0000
+++ binutils/gas/configure 2018-01-20 11:16:26.894145984 +0000
@@ -12380,7 +12380,8 @@ _ACEOF
esac
# Decide which ABI to target by default.
case ${target} in
- mips64*-linux* | mips-sgi-irix6* | mips64*-freebsd* | mips64*-kfreebsd*-gnu)
+ mips64*-linux* | mips-sgi-irix6* | mips64*-freebsd* \
+ | mips64*-kfreebsd*-gnu | mips64*-ps2-elf*)
mips_default_abi=N32_ABI
;;
mips*-linux* | mips*-freebsd* | mips*-kfreebsd*-gnu)
Index: binutils/gas/configure.ac
===================================================================
--- binutils.orig/gas/configure.ac 2018-01-19 18:37:43.000000000 +0000
+++ binutils/gas/configure.ac 2018-01-20 11:15:34.254129179 +0000
@@ -345,7 +345,8 @@ changequote([,])dnl
esac
# Decide which ABI to target by default.
case ${target} in
- mips64*-linux* | mips-sgi-irix6* | mips64*-freebsd* | mips64*-kfreebsd*-gnu)
+ mips64*-linux* | mips-sgi-irix6* | mips64*-freebsd* \
+ | mips64*-kfreebsd*-gnu | mips64*-ps2-elf*)
mips_default_abi=N32_ABI
;;
mips*-linux* | mips*-freebsd* | mips*-kfreebsd*-gnu)