Re: [patches] Re: [PATCH] RISC-V: Support for FreeBSD

[Kito Cheng <kito dot cheng at gmail dot com>]

Hi Nick:


> Does this actually work ?
Yes, it's work, I guess it's just because like Jim said, however
Ruslan and me will update and test it again, thanks!

Hi Jim:

Thanks your comment, I will fix the order and try again.


On Tue, Jan 30, 2018 at 3:31 AM, Jim Wilson <jimw@sifive.com> wrote:
> On 01/29/2018 06:08 AM, Nick Clifton wrote:
>>
>> Hi Kito,
>>
>>> This patch enable RISC-V support FreeBSD, Ruslan (RISC-V FreeBSD
>>> maintainer) and me has been tested on FreeBSD 12 for building kernel
>>> and whole user space programs/libraries.
>>
>>
>> Does this actually work ?
>>
>>>
>>>     riscv*-*-*)                 fmt=elf endian=little ;;
>>> +  riscv*-*-freebsd*)                   fmt=elf endian=little em=freebsd
>>> ;;
>>
>>   To me it looks like the first line will match "riscv-freebsd" as well,
>> and since it has precedence the freebsd emulation parameter will not be
>> set.
>
>
> It does not work, for precisely the reason you mentioned.
>
> It also appears pointless, as the only difference between te-generic.h and
> te-freebsd.h is the define of TE_FreeBSD in the latter, but that is not used
> anywhere in the RISC-V port.  So maybe that is why it "works", because it is
> unnecessary.  But that also means it is harmless and won't break anything if
> it goes in, with the order fixed of course.
>
> I also don't see a copyright assignment for Ruslan.  This is probably OK as
> a trivial patches, but if there are more patches coming we would need a
> copyright assignment.
>
> Jim
>
> --
> You received this message because you are subscribed to the Google Groups
> "RISC-V Patches" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to patches+unsubscribe@groups.riscv.org.
> To post to this group, send email to patches@groups.riscv.org.
> Visit this group at
> https://groups.google.com/a/groups.riscv.org/group/patches/.
> To view this discussion on the web visit
> https://groups.google.com/a/groups.riscv.org/d/msgid/patches/09c0a5ac-39f3-ca6d-43aa-2d7951a28911%40sifive.com.
>
> For more options, visit
> https://groups.google.com/a/groups.riscv.org/d/optout.