Re: [PATCH] gas: xtensa: fix trampoline placement

[Max Filippov <jcmvbkbc at gmail dot com>]

Hi Nick,

On Mon, Feb 12, 2018 at 4:08 AM, Nick Clifton <nickc@redhat.com> wrote:
>   Would you mind updating your recent commits please ?
>
>> +         /* Don't choose trampoline that contains the source.  */
>> +         if (source >= trampoline_frag->fr_address &&
>> +             source <= trampoline_frag->fr_address + trampoline_frag->fr_fix)
>> +           continue;
>
>   The GNU Coding standard requires that boolean conditional
>   operators should be at the start of a line, not the end:
>
> https://www.gnu.org/prep/standards/html_node/Formatting.html#Formatting
>
>   So the above fragment, for example, should be:
>
>             /* Don't choose trampoline that contains the source.  */
>             if (source >= trampoline_frag->fr_address
>                 && source <= trampoline_frag->fr_address + trampoline_frag->fr_fix)
>               continue;

Thanks for the review. Will fix that.

-- 
Thanks.
-- Max