This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Linker plugins should be aware of --defsym during symbol resolution

From: Cary Coutant <ccoutant at gmail dot com>
To: Sriraman Tallam <tmsriram at google dot com>
Cc: Teresa Johnson <tejohnson at google dot com>, binutils <binutils at sourceware dot org>, David Li <davidxl at google dot com>
Date: Mon, 12 Feb 2018 12:26:01 -0800
Subject: Re: Linker plugins should be aware of --defsym during symbol resolution
Authentication-results: sourceware.org; auth=none
References: <CAAs8HmztRc_qZ3Kqxf1EwQ+mTPZnpoUs0cSRvda_wYnES++pCQ@mail.gmail.com> <CAAs8HmwHSePozy-kRgsBJW9f8g4wKqV6dqdZnMYDBK+WXy8OOQ@mail.gmail.com> <CAJimCsG3uYRF_8FW15bA1s3ePS53398yJQGTvWaSGYrk9hy6-w@mail.gmail.com>

> Hmmm, in get_symbol_resolution_info, we have this:
>
>   if (nsyms > this->nsyms_)
>     return LDPS_NO_SYMS;
>
> That needs to be qualified with a test for version > 2 (as was done a
> few lines below).

Ignore this -- we always returned NO_SYMS in this case, but added the
new case just below with LDPT_GET_SYMBOLS_V3. Sorry!

-cary

References:
- Linker plugins should be aware of --defsym during symbol resolution
  - From: Sriraman Tallam via binutils
- Re: Linker plugins should be aware of --defsym during symbol resolution
  - From: Sriraman Tallam via binutils
- Re: Linker plugins should be aware of --defsym during symbol resolution
  - From: Cary Coutant

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]