This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] RISC-V: Add .insn support
- From: Andrew Waterman <andrew at sifive dot com>
- To: Kito Cheng <kito dot cheng at gmail dot com>
- Cc: patches at groups dot riscv dot org, binutils at sourceware dot org, Jim Wilson <jimw at sifive dot com>, Palmer Dabbelt <palmer at sifive dot com>
- Date: Wed, 7 Mar 2018 02:04:11 -0800
- Subject: Re: [PATCH] RISC-V: Add .insn support
- Authentication-results: sourceware.org; auth=none
- References: <CA+yXCZBQzKaayVkTp5op_oniqhW5GZodTwvRZYEcA8oBb9VTQA@mail.gmail.com>
Hi Kito,
Thanks for contributing this patch. I did not thoroughly review the
code, but I like the approach. Jim or Palmer will probably follow up
with additional comments.
I noticed a typo: major opcode 0x6f should be named JAL, not JAR.
(The test case and the documentation also have this typo.)
Andrew
On Wed, Mar 7, 2018 at 1:15 AM, Kito Cheng <kito.cheng@gmail.com> wrote:
> This patch make RISC-V assembler support new directive: .insn, it
> able to write instruction with another form just like s/390's .insn
> directive.
>
> Main purpose of this directive is to make people easier to add new
> instruction for experimentation without modify binutils, and it's much
> usable than just use .word to encode instruction.
>
>
> [1] https://sourceware.org/binutils/docs-2.30/as/s390-Directives.html#index-_002einsn-directive_002c-s390