This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: adjust 4-XMM-register-group related warning
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Beulich <JBeulich at suse dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Wed, 7 Mar 2018 04:25:06 -0800
- Subject: Re: [PATCH] x86: adjust 4-XMM-register-group related warning
- Authentication-results: sourceware.org; auth=none
- References: <5A9FAE8202000078001AF3EB@prv-mh.provo.novell.com>
On Wed, Mar 7, 2018 at 12:18 AM, Jan Beulich <JBeulich@suse.com> wrote:
> Drop "second": For one there's no other source register (the other
> source operand is in memory), and in Intel syntax such numbering would
> also be wrong.
>
> Take the opportunity and also
> - properly place declarations ahead of statements
> - use %u format for unsigned int arguments
> - fix indentation
>
> gas/
> 2018-03-07 Jan Beulich <jbeulich@suse.com>
>
> * config/tc-i386.c (process_operands): Access operands only
> after operand count assertion. Sanitize warning text. Fix
> indentation.
> * testsuite/gas/i386/avx512_4fmaps-warn.l,
> gas/i386/x86-64-avx512_4fmaps-warn.l: Adjust expectations.
>
OK.
Thanks.
--
H.J.