This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH 4/6] x86: change AVX512VL handling in cpu_flags_match()
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: <binutils at sourceware dot org>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Wed, 07 Mar 2018 06:03:04 -0700
- Subject: [PATCH 4/6] x86: change AVX512VL handling in cpu_flags_match()
- Authentication-results: sourceware.org; auth=none
- References: <5A9FF00602000078001AF5C9@prv-mh.provo.novell.com>
In order to add an AVX512F counterpart to the present AVX checking, it
is better to move the AVX512VL check out of the conditional it's
currently in.
gas/
2018-03-07 Jan Beulich <jbeulich@suse.com>
* config/tc-i386.c (cpu_flags_match): Move AVX512VL check ahead.
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -1710,6 +1710,11 @@ cpu_flags_match (const insn_template *t)
/* This instruction is available only on some archs. */
i386_cpu_flags cpu = cpu_arch_flags;
+ /* AVX512VL is no standalone feature - match it and then strip it. */
+ if (x.bitfield.cpuavx512vl && !cpu.bitfield.cpuavx512vl)
+ return match;
+ x.bitfield.cpuavx512vl = 0;
+
cpu = cpu_flags_and (x, cpu);
if (!cpu_flags_all_zero (&cpu))
{
@@ -1722,17 +1727,6 @@ cpu_flags_match (const insn_template *t)
&& (!x.bitfield.cpupclmul || cpu.bitfield.cpupclmul))
match |= CPU_FLAGS_ARCH_MATCH;
}
- else if (x.bitfield.cpuavx512vl)
- {
- /* Match AVX512VL. */
- if (cpu.bitfield.cpuavx512vl)
- {
- /* Need another match. */
- cpu.bitfield.cpuavx512vl = 0;
- if (!cpu_flags_all_zero (&cpu))
- match |= CPU_FLAGS_ARCH_MATCH;
- }
- }
else
match |= CPU_FLAGS_ARCH_MATCH;
}