This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] RISC-V: Add .insn support
- From: Jim Wilson <jimw at sifive dot com>
- To: Andrew Waterman <andrew at sifive dot com>
- Cc: Kito Cheng <kito dot cheng at gmail dot com>, RISC-V Patches <patches at groups dot riscv dot org>, binutils at sourceware dot org, Palmer Dabbelt <palmer at sifive dot com>
- Date: Wed, 7 Mar 2018 10:21:28 -0800
- Subject: Re: [PATCH] RISC-V: Add .insn support
- Authentication-results: sourceware.org; auth=none
- References: <CA+yXCZBQzKaayVkTp5op_oniqhW5GZodTwvRZYEcA8oBb9VTQA@mail.gmail.com> <CA++6G0DaCzRkk=snQYgsPM8+xBNMOXeAv5sRcGehrCK7K_1f6Q@mail.gmail.com>
On Wed, Mar 7, 2018 at 2:04 AM, Andrew Waterman <andrew@sifive.com> wrote:
> Thanks for contributing this patch. I did not thoroughly review the
> code, but I like the approach. Jim or Palmer will probably follow up
> with additional comments.
I looked at the previous version of the patch a month or so ago, and
the only curious thing I noticed is that the 4-operand instruction
pattern has type I, but in the ISA these are only used for FP
instructions. I'm not sure if this can be fixed though, since we
don't have any category that covers all FP extensions: F, D, Q. Plus
someone might want to try using a 4-operand instruction with integer
operands so it is probably reasonable to allow that.
My schedule is very hectic at the moment, as I'm in the middle of
moving to a new home closer to work. I should be able to find time to
look at this new version of the patch sometime soon.
Jim