This is the mail archive of the crossgcc@sources.redhat.com mailing list for the crossgcc project.

See the CrossGCC FAQ for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: another possible crosstool cleanup


Robert P. J. Day wrote:
  it's not clear why the "getandpatch" script checks for values in
the TARGET and TARGET_CFLAGS variables, since those variables are not
used in this script.  just a cut and paste thing, i assume.

True, thanks.


BTW I am tempted to reorganize the scripts like this:
1. move all code into a single file, 'functions.sh',
as shell functions, one per build phase, probably ten functions in all
2. turn crosstool.sh into
      . functions.sh
   followed by calls to each of the ten or so functions
The environment variable sanity checks that are now cut-and-pasted
all over the place would then be concentrated at the top of functions.sh.

The goal is reducing duplicated code and increased readability.
- Dan

--
Dan Kegel
http://www.kegel.com
http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045


------ Want more information? See the CrossGCC FAQ, http://www.objsw.com/CrossGCC/ Want to unsubscribe? Send a note to crossgcc-unsubscribe@sources.redhat.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]