This is the mail archive of the crossgcc@sources.redhat.com mailing list for the crossgcc project.

See the CrossGCC FAQ for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] to not include a currently-included file in sanitizedheaders


On Mon, 2 May 2005, Daniel Kegel wrote:

> Robert P. J. Day wrote:
> >   based on a conversation i had with the maintainer of the sanitized
> > headers, this removes a single include from one of the header files
> > that causes a problem.
> >
> >
> >
> > --- linux-libc-headers-2.6.11.2/include/asm-sh/ptrace.h.orig	2005-05-02
> > 16:48:15.000000000 -0400
> > +++ linux-libc-headers-2.6.11.2/include/asm-sh/ptrace.h	2005-05-02
> > 16:48:28.000000000 -0400
> > @@ -1,7 +1,7 @@
> >  #ifndef __ASM_SH_PTRACE_H
> >  #define __ASM_SH_PTRACE_H
> >
> > -#include <asm/ubc.h>
> > +/* #include <asm/ubc.h> */
> >
> >  /*
> >   * Copyright (C) 1999, 2000  Niibe Yutaka
>
> Looks great, thanks!  And thanks for coordinating with the
> maintainer, Mariusz Mazur <mmazur /at/ kernel.pl>.
>
> When you post patches, though, could you include the
> error message that it fixes?

good point, and perhaps you can clarify something.  if you use just
the sanitized headers and not the full kernel source, obviously you're
not going to do any configuration and, consequently, if you look under
the include/ directory, you'll see all of:

  asm-alpha/
  asm-arm/
  asm-arm26/

and so on.  however, because of no configuration, you'll never have
the appropriate symlink, say, asm->asm-sh.

what that means is that you better never incorporate a header file
that contains anything of the form:

  #include <asm/whatever.h>

since it's guaranteed to fail.  that's what happened with
include/asm-sh/ptrace.h -- it included <asm/ubc.h> and choked.  so
just commenting out that single include directive was the patch.

  at least, that's what i get out of perusing the header files.
thoughts?

rday


------
Want more information?  See the CrossGCC FAQ, http://www.objsw.com/CrossGCC/
Want to unsubscribe? Send a note to crossgcc-unsubscribe@sources.redhat.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]