Re: [CT-NG] eglibc optim cflags

[Arnaud Vrac <avrac at freebox dot fr>]

Yann E. MORIN wrote:
> Arnaud,
> All,
>
> On Friday 09 October 2009 14:06:20 Arnaud Vrac wrote:
> > Is there any way to force eglibc to compile with -Os besides editing the 
> > build script ? I tested that this works so it should be possible to do 
> > it from the configuration files.
>
> Yes, please, provide a patch! :-)

I'm not sure where to put the default optimisation cflags. Should we 
allow the TARGET_CFLAGS to override them ? Or do we only allow the libc 
cflags to override them ?

I saw that there were some problems building eglibc with some 
optimisations like -O so I'd be in favor of the second option.

Regards,

--
Arnaud Vrac

# HG changeset patch
# User Arnaud Vrac <avrac@freebox.fr>
# Date 1255098531 -7200
# Node ID ef521b359e491d0be7104a7637e2886a076dc4eb
# Parent  503237de146a58b98c96a86c15cd4254ae85eb6d
glibc/eglibc: allow optimisation cflags to be overriden by configuration.

Signed-off-by: Arnaud Vrac <avrac@freebox.fr>

diff -r 503237de146a -r ef521b359e49 scripts/build/libc/eglibc.sh
--- a/scripts/build/libc/eglibc.sh	Fri Oct 09 16:22:09 2009 +0200
+++ b/scripts/build/libc/eglibc.sh	Fri Oct 09 16:28:51 2009 +0200
@@ -301,7 +301,7 @@
     CT_DoLog DEBUG "Extra CC args passed    : '${extra_cc_args}'"
 
     BUILD_CC="${CT_BUILD}-gcc"                                      \
-    CFLAGS="${CT_TARGET_CFLAGS} ${CT_LIBC_GLIBC_EXTRA_CFLAGS} -O2"  \
+    CFLAGS="${CT_TARGET_CFLAGS} -O2 ${CT_LIBC_GLIBC_EXTRA_CFLAGS}"  \
     CC="${CT_TARGET}-gcc ${CT_LIBC_EXTRA_CC_ARGS} ${extra_cc_args}" \
     AR=${CT_TARGET}-ar                                              \
     RANLIB=${CT_TARGET}-ranlib                                      \
diff -r 503237de146a -r ef521b359e49 scripts/build/libc/glibc.sh
--- a/scripts/build/libc/glibc.sh	Fri Oct 09 16:22:09 2009 +0200
+++ b/scripts/build/libc/glibc.sh	Fri Oct 09 16:28:51 2009 +0200
@@ -317,7 +317,7 @@
     # Please see the comment for the configure step in do_libc().
 
     BUILD_CC="${CT_BUILD}-gcc"                                      \
-    CFLAGS="${CT_TARGET_CFLAGS} ${CT_LIBC_GLIBC_EXTRA_CFLAGS} -O2"  \
+    CFLAGS="${CT_TARGET_CFLAGS} -O2 ${CT_LIBC_GLIBC_EXTRA_CFLAGS}"  \
     CC="${cross_cc} ${CT_LIBC_EXTRA_CC_ARGS} ${extra_cc_args}"      \
     AR=${CT_TARGET}-ar                                              \
     RANLIB=${CT_TARGET}-ranlib                                      \
@@ -443,7 +443,7 @@
     # silly messages. GNU folks again, he?
 
     BUILD_CC="${CT_BUILD}-gcc"                                      \
-    CFLAGS="${CT_TARGET_CFLAGS} ${CT_LIBC_GLIBC_EXTRA_CFLAGS} -O2"  \
+    CFLAGS="${CT_TARGET_CFLAGS} -O2 ${CT_LIBC_GLIBC_EXTRA_CFLAGS}"  \
     CC="${CT_TARGET}-gcc ${CT_LIBC_EXTRA_CC_ARGS} ${extra_cc_args}" \
     AR=${CT_TARGET}-ar                                              \
     RANLIB=${CT_TARGET}-ranlib                                      \

--
For unsubscribe information see http://sourceware.org/lists.html#faq