Re: [PATCH 3 of 3] Add IBM s390x architecture and sample

["Yann E. MORIN" <yann dot morin dot 1998 at anciens dot enib dot fr>]

Harold,
All,

All-in-all, the same comments as for the previous patch still apply,
plus the ones below.

On Wednesday 11 November 2009 18:40:30 Harold Grovesteen wrote:
> +# Target options
> +#
> +CT_ARCH="s390x"
> +CT_ARCH_64=y
> +# CT_ARCH_SUPPORTS_BOTH_MMU is not set
> +# CT_ARCH_SUPPORTS_BOTH_ENDIAN is not set
> +# CT_ARCH_SUPPORT_ARCH is not set
> +# CT_ARCH_SUPPORT_ABI is not set
> +# CT_ARCH_SUPPORT_CPU is not set
> +# CT_ARCH_SUPPORT_TUNE is not set
> +CT_ARCH_SUPPORT_FPU=y
> +CT_ARCH_DEFAULT_HAS_MMU=y
> +CT_ARCH_DEFAULT_BE=y
> +# CT_ARCH_DEFAULT_LE is not set
> +CT_ARCH_FPU=""
> +CT_ARCH_FLOAT_HW=y
> +# CT_ARCH_FLOAT_SW is not set
> +CT_TARGET_CFLAGS="-O"

Hmmm. I don't know. -O is overriden by glibc/eglibc to -O2, and
I'm not sure gcc makes (a proper) use of CT_TARGET_CFLAGS.

Also applies to your previous patch.

> +CT_BINUTILS_EXTRA_CONFIG="--enable-64-bit-bfd"

This should be done in the binutils build script, when the target is
64-bit. Prepare a separate patch.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'



--
For unsubscribe information see http://sourceware.org/lists.html#faq