This is the mail archive of the crossgcc@sourceware.org mailing list for the crossgcc project.

See the CrossGCC FAQ for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2 of 3] Add IBM s390 architecture and sample


Harold,
All,

On Wednesday 11 November 2009 23:30:05 Harold Grovesteen wrote:
> How to get back to a state where there are no patches and I am just 
> working from my changes?  Or is that even necessary.

Have a look at the MQ extension documentation:
http://mercurial.selenic.com/wiki/MqExtension

> Yann E. MORIN wrote:
[--SNIP--]
> >>+# CT_FORCE_EXTRACT is not set
> >>+CT_OVERIDE_CONFIG_GUESS_SUB=y
> >>+# CT_ONLY_EXTRACT is not set
> >>+# CT_PATCH_BUNDLED is not set
> >>+CT_PATCH_LOCAL=y
> >>+# CT_PATCH_BUNDLED_LOCAL is not set
> >>+# CT_PATCH_LOCAL_BUNDLED is not set
> >>+# CT_PATCH_BUNDLED_FALLBACK_LOCAL is not set
> >>+# CT_PATCH_LOCAL_FALLBACK_BUNDLED is not set
> >>+CT_PATCH_ORDER="local"
> >>+# CT_PATCH_SINGLE is not set
> >>+CT_PATCH_USE_LOCAL=y
> >>+CT_LOCAL_PATCH_DIR="$HOME/crosstool/patches"
> >If you have local patches you do not include in crosstool-NG, then the
> >sample is useless. Please add the patches in crosstool-NG.
> No, local patches.  When I started I put this in the config in case I 
> needed any.  Just needs to be cleaned up.

The problem is that if you don't have local patches, the above configuration
does not even apply the patches bundled with crosstool-NG.

> By "clean" do you mean that the statement needs to be removed from the 
> sample before patching?

Re-create the sample when the s390x support is not yet integrated.

> >>+CT_CC_EXTRA_CONFIG="--with-tls --with-__thread"
> >I'm uneasy with those. Are they really needed? Normally, the ./configure
> >for gcc will automatically detect if TLS and threads are supported, and
> >it should not be needed to manually specify them.
> I had used crosstool.  Wanting to start with a somewhat known state, I 
> may have added these because crosstool used them in its configure.  I 
> will remove and retest.  Any suggestion as to how to determine if the 
> correct settings are used would be appreciated.  A clean run would not 
> prove the correct settings were used.  Any suggestion as to how to 
> determine if the correct settings are used would be appreciated.

You could look at the config.log file in the gcc build directory:
targets/s390......./build/build-cc/config.log and search for
TLS and threads messages.

It is working for all other archs (x86, x86_64, arm, mips...) so there's
no reason it would not work for s390...

> >You provide a patch against dmalloc (in a previous mail), but don't
> >use it? How did you conclude that dmalloc needed that patch (when in
> >fact it definitely does not) ?
> As I mentioned previously, I never got dmalloc to compile and gave up on 
> the other debug tools.  The patch should be removed.
> How do I eliminate this patch from being created?

Run "hg qpop" until you are at the correct patch.
Then: hg revert scripts/debug/100-dmalloc.sh
And finally: hg qrefresh

> >Do not change CT_TARGET_ARCH and CT_KERNEL_ARCH: you only need to do so if
> >the real architecture name does not match the configure name (that appears
> >in the menus). In your case, you don't need to
> Did not know that.  I simply read the architecture section in the 
> overview.txt which seemed to indicate I needed to do this.  Will remove.

OK, I'll fix that to be more explicit. Thanks for the feedback!

> >All-in-all, that's quite correct. Can you address all those issues, please?
> >Keep up the work, we'll manage something! :-)
> Happily and appreciate the feedback.

Good! I'm glad you're going through all this! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'



--
For unsubscribe information see http://sourceware.org/lists.html#faq


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]