Re: [patch 01/10] Force autoreconf for mpfr

[Bart van der Meulen <bartvdrmeulen at gmail dot com>]

2010/5/29 Remy Bohmer <linux@bohmer.net>:
> Hi Yann,
>
> 2010/5/29 Yann E. MORIN <yann.morin.1998@anciens.enib.fr>:
>> Remy, All,
>>
>> On Thursday 27 May 2010 23:18:10 Remy Bohmer wrote:
>>> In some exotic case the autoreconf step of mpfr is not executed (correctly)
>>> leaving an incorrect version number for libtool in the configure script.
>>>
>>> After extracting the sources files, force autoreconf to be executed.
>>>
>>> Signed-off-by: Bart vdr. Meulen <bartvdrmeulen@gmail.com>
>>> ---
>>> ?scripts/build/companion_libs/mpfr.sh | ? ?2 +-
>>> ?1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> Index: crosstool-ng/scripts/build/companion_libs/mpfr.sh
>>> ===================================================================
>>> --- crosstool-ng.orig/scripts/build/companion_libs/mpfr.sh
>>> +++ crosstool-ng/scripts/build/companion_libs/mpfr.sh
>>> @@ -34,7 +34,7 @@ do_mpfr_extract() {
>>> ? ? ? ? ? ? ?CT_Pushd "${CT_SRC_DIR}/mpfr-${CT_MPFR_VERSION}"
>>> ? ? ? ? ? ? ?if [ ! -f .autoreconf.ct-ng ]; then
>>> ? ? ? ? ? ? ? ? ?CT_DoLog DEBUG "Running autoreconf"
>>> - ? ? ? ? ? ? ? ?CT_DoExecLog ALL autoreconf
>>> + ? ? ? ? ? ? ? ?CT_DoExecLog ALL autoreconf -fi
>>
>> I'd like that you explain what those "exotic cases" are. The patch breaks
>> the build on my machine (Debian Lenny + backports):
>> ?# autoreconf --version
>> ?autoreconf (GNU Autoconf) 2.65
>> ?# libtool --version
>> ?ltmain.sh (GNU libtool) 1.5.26 Debian 1.5.26-4+lenny1 (1.1220.2.493
>> ?2008/02/01 16:58:18)
>
> Oops that was indeed what you mentioned already earlier. I was to
> focused on merging all the patches back in on top of mainline that I
> forgot that this particular patch did not work on your system. IIRC
> this patch had something to do with our build-server which is a RHEL5
> machine, and the exotic case was probably related to this machine, but
> Bart could maybe provide you some more info about it next week.
>
> At least the complete series is merged back in again on top of the
> current mainline and it is working properly.
> Please take a look at the other patches and if those are okay, please
> pull them in.
>
> Kind regards,
>
> Remy
>

Hi,

Like Remy said our build server is a RHEL5 machine, that what our IT
wants to support, while our own build is based on a Ubuntu 8
installation,
so in order to build on the build server, during the build we perform
a chroot to a ext2-image file containing a Ubuntu installation and
perform the actual
build inside this environment (how is that for exotic)

During the toolchain build we got some errors on in the mpfr build. It
was some time ago I traced the problem and I forgot most of the
details,
but what I remember is that reconf failed to update some files,
resulting is a build failure unless it was forced to recreate all
files.
Using the '-fi' option fixed the build in Ubuntu environment on build
server and did not break the build on our own native Ubuntu machines.

versions:
# autoreconf --version
autoreconf (GNU Autoconf) 2.61
# libtool --version
ltmain.sh (GNU libtool) 2.2.4

Bart

--
For unsubscribe information see http://sourceware.org/lists.html#faq