Re: [PATCH 3 of 3] mingw32: enable sysrooted toolchains

["Yann E. MORIN" <yann dot morin dot 1998 at anciens dot enib dot fr>]

Arnaud, All,

On Sunday 15 August 2010 00:21:55 Arnaud Lacombe wrote:
> On Sat, Aug 14, 2010 at 5:58 PM, Yann E. MORIN
> <yann.morin.1998@anciens.enib.fr> wrote:
> > When targeting mingw32, gcc expects to find its include files
> > in "minw/include" instead of the traditional "usr/include".
> no, it does not. It is "mingw/include" not "minw/include".

Typo that's already fixed here. Thank you.

> > [Yann E. MORIN: split the original patch]
> why ?

Because the two other hunks are independent from this one.

> > diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
> > --- a/scripts/build/cc/gcc.sh
> > +++ b/scripts/build/cc/gcc.sh
> > @@ -428,7 +428,13 @@
> > ? ? fi
> >
> > ? ? CT_DoLog EXTRA "Building final compiler"
> > + ? ?if [ "${CT_MINGW32}" = "y" ]; then
> > + ? ? ? ?CT_DoExecLog ALL ln -sv "usr" "${CT_SYSROOT_DIR}/mingw"
> > + ? ?fi
> > ? ? CT_DoExecLog ALL make ${PARALLELMFLAGS} all
> > + ? ?if [ "${CT_MINGW32}" = "y" ]; then
> > + ? ? ? ?CT_DoExecLog ALL rm "${CT_SYSROOT_DIR}/mingw"
> > + ? ?fi
> >
> mwarf...

As my intro message stated: "for review/comments"
So now is a good time for *you* to come up with a *better* solution if you
find this one ugly (which you seem to do).

I am sorry to tell you that being so much irrespectful as you are is
not very contructive. :-(

> > diff --git a/scripts/build/libc/mingw.sh b/scripts/build/libc/mingw.sh
> > --- a/scripts/build/libc/mingw.sh
> > +++ b/scripts/build/libc/mingw.sh
> > @@ -65,6 +65,7 @@
> > ? ? CT_DoExecLog ALL ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> > ? ? "${CT_SRC_DIR}/w32api-${CT_W32API_VERSION}-mingw32/configure" \
> > ? ? ? ? --prefix=${CT_SYSROOT_DIR} ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> > + ? ? ? ?--includedir=${CT_HEADERS_DIR} ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> > ? ? ? ? --host=${CT_TARGET}
> >
> > ? ? CT_DoLog EXTRA "Building W32-API"
> > @@ -83,6 +84,7 @@
> > ? ? CT_DoExecLog ALL ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> > ? ? "${CT_SRC_DIR}/mingwrt-${CT_MINGWRT_VERSION}-mingw32/configure" \
> > ? ? ? ? --prefix=${CT_SYSROOT_DIR}/ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
> > + ? ? ? ?--includedir=${CT_HEADERS_DIR} ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> > ? ? ? ? --host=${CT_TARGET}
> >
> > ? ? CT_DoLog EXTRA "Building MinGW Runtime"
> > @@ -120,7 +122,7 @@
> > ? ? ? ? CT_DoLog EXTRA "Installing PDCurses development files"
> > ? ? ? ? chmod a+r ${CT_SRC_DIR}/PDCurses-${CT_MINGW_PDCURSES_VERSION}/*.h
> > ? ? ? ? cp ${CT_SRC_DIR}/PDCurses-${CT_MINGW_PDCURSES_VERSION}/*.h \
> > - ? ? ? ? ? ${CT_HEADERS_DIR}
> > + ? ? ? ? ? ${CT_HEADERS_DIR}/
> > ? ? ? ? cp pdcurses.a ${CT_SYSROOT_DIR}/lib/libpdcurses.a
> > ? ? ? ? cp pdcurses.a ${CT_SYSROOT_DIR}/lib/libncurses.a
> > ? ? fi
> how does these relate to gcc ?

I never said the patch was only related to gcc. As stated in the short
commit message: "mingw32: enable sysrooted toolchain"

It can touch as many files as needed to implement the feature.
But the commit message should have also said smthg like:
  > And point companion target libs to the proper include path.

But again, if you find that the commit message is not explanatory enough,
come up with a better wording.

> > @@ -134,10 +136,11 @@
> > ? ? ? ? CFLAGS="${CT_CFLAGS_FOR_TARGET}" ? ? ? ? ? ? ? ?\
> > ? ? ? ? CT_DoExecLog ALL ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> > ? ? ? ? "${CT_SRC_DIR}/mingw-libgnurx-${CT_MINGW_GNURX_VERSION}/configure" \
> > - ? ? ? ? ? ?--build=${CT_BUILD} ? ? ? ? ? \
> > - ? ? ? ? ? ?--host=${CT_TARGET} ? ? ? ? ? \
> > - ? ? ? ? ? ?--prefix=${CT_SYSROOT_DIR} ? ?\
> > - ? ? ? ? ? ?--enable-shared ? ? ? ? ? ? ? \
> > + ? ? ? ? ? ?--build=${CT_BUILD} ? ? ? ? ? ? \
> > + ? ? ? ? ? ?--host=${CT_TARGET} ? ? ? ? ? ? \
> > + ? ? ? ? ? ?--prefix=${CT_SYSROOT_DIR} ? ? ?\
> sic... there is one argument per line to avoid diff mess, but

Initially, it was essentially for readbility. That it makes it easier to
avoid diff-mess is a side-effect, and was not meant to avoid it.

> adjusting the spaces creates a diff mess :/

Well, that one can be split-up in a feat-fix + a space-damage-fix, if
needed. I'll do.

But please, Arnaud, don't be so aggressive. You are on the verge of
being kill-filed here... And that's not something I do very often. :-(

That I post the patches to the list _before_ I push to the repo was *your*
idea, not mine. So far, I have seen *no* single _pertinent_ comment or
review, and most notably not even by *you*.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq