This is the mail archive of the crossgcc@sourceware.org mailing list for the crossgcc project.

See the CrossGCC FAQ for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] kernel/linux: Cleanup all unneeded files from 'headers_check' and 'headers_install'


On Tue, Dec 21, 2010 at 9:20 AM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Bryan, All,
>
> On Tuesday 21 December 2010 01:55:25 Bryan Hundven wrote:
>> diff -r 13e4f7126cf7 -r dceb4bf2e188 scripts/build/kernel/linux.sh
>> --- a/scripts/build/kernel/linux.sh  Tue Dec 14 11:49:18 2010 -0800
>> +++ b/scripts/build/kernel/linux.sh  Mon Dec 20 16:54:30 2010 -0800
>> @@ -112,7 +112,7 @@
>> Â Â Â Â Â Â Â INSTALL_HDR_PATH="${CT_SYSROOT_DIR}/usr" Â Â Â \
>> Â Â Â Â Â Â Â ${V_OPT} Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \
>> Â Â Â Â Â Â Â headers_check
>> - Â Â Â Âfind "${CT_SYSROOT_DIR}" -type f -name '.check*' -exec rm {} \;
>> + Â Â Â Âfind "${CT_SYSROOT_DIR}" -type f -name '.*install*' -o -name '.*check*' | xargs rm
>
> Why not something like:
> Âfind "${CT_SYSROOT_DIR}" -type f         Â\
> Â Â Â \( -name '.*install*' -o -name '.*check*' \) \
> Â Â Â -exec rm {} \;
>
> Then, I can see why the '.check*' did not match. There are only four types of
> files being installed:
> Â.check
> Â..check.cmd
> Â.install
> Â..install.cmd

Technically, only 3:

..check.cmd
.install
..install.cmd

> Can't we use the full, known names instead of the wildcards?

I don't see why not. I will push a new patch today.

> Regards,
> Yann E.MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | ÂYann E. MORIN Â| Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software ÂDesigner | \ / CAMPAIGN Â Â | Â___ Â Â Â Â Â Â Â |
> | +33 223 225 172 `------------.-------: ÂX ÂAGAINST Â Â Â| Â\e/ ÂThere is no Â|
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL  Â|  v  conspiracy. Â|
> '------------------------------^-------^------------------^--------------------'
>

-Bryan

--
For unsubscribe information see http://sourceware.org/lists.html#faq


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]