Re: [PATCH] kernel/linux: Cleanup unneeded files from 'headers_check' and 'headers_install'

[Bryan Hundven <bryanhundven at gmail dot com>]

On Tue, Dec 21, 2010 at 2:50 PM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Bryan, All,
>
> On Tuesday 21 December 2010 21:14:33 Bryan Hundven wrote:
>> # HG changeset patch
>> # User Bryan Hundven <bryanhundven@gmail.com>
>> # Date 1292962441 28800
>> # Node ID 92951c85f1f2810fdedc29d9576c3cc316e0bb86
>> # Parent Â13e4f7126cf76604d53510f9571e6422991774fd
>> kernel/linux: Cleanup unneeded files from 'headers_check' and 'headers_install'
>>
>> headers_install makes Â.install and ..install.cmd files.
>> headers_check makes  Â.check  and ..check.cmd  files.
>> Remove these files after installing checked include files to the sys-root.
>>
>> diff -r 13e4f7126cf7 -r 92951c85f1f2 scripts/build/kernel/linux.sh
>> --- a/scripts/build/kernel/linux.sh  Tue Dec 14 11:49:18 2010 -0800
>> +++ b/scripts/build/kernel/linux.sh  Tue Dec 21 12:14:01 2010 -0800
>> @@ -112,7 +112,10 @@
>> Â Â Â Â Â Â Â INSTALL_HDR_PATH="${CT_SYSROOT_DIR}/usr" Â Â Â \
>> Â Â Â Â Â Â Â ${V_OPT} Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \
>> Â Â Â Â Â Â Â headers_check
>> - Â Â Â Âfind "${CT_SYSROOT_DIR}" -type f -name '.check*' -exec rm {} \;
>> + Â Â Â Âfind "${CT_SYSROOT_DIR}" -type f '(' -name '.install' \
>> + Â Â Â Â Â Â-o -name '.check' Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \
>> + Â Â Â Â Â Â-o -name '..install.cmd' Â Â Â Â Â Â Â Â Â Â Â Â Â\
>> + Â Â Â Â Â Â-o -name '..check.cmd' ')' -exec rm '{}' \;
>> Â Â Âfi
>> Â}
>
> We have to do it even if the user did not choose to run headers_check,
> because the .cinstall an d ..install.cmd files will always be installed.
> So it has to go outside of the conditional.

I guess we could also have two find statements, one inside the
conditional for headers_check and one outside.

> I'll apply your patch with this change, no need to re-submit.

But that works for me ;)

> Thank you! :-)
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | ÂYann E. MORIN Â| Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software ÂDesigner | \ / CAMPAIGN Â Â | Â___ Â Â Â Â Â Â Â |
> | +33 223 225 172 `------------.-------: ÂX ÂAGAINST Â Â Â| Â\e/ ÂThere is no Â|
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL  Â|  v  conspiracy. Â|
> '------------------------------^-------^------------------^--------------------'
>


Thanks, Yann!

-Bryan

--
For unsubscribe information see http://sourceware.org/lists.html#faq