Re: [PATCH] glibc: Refactor startfiles/headers into do_libc

[Bryan Hundven <bryanhundven at gmail dot com>]

On Thu, Jun 23, 2011 at 4:19 PM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Bryan, All,
>
> On Thursday 23 June 2011 04:41:45 Bryan Hundven wrote:
>> On Wed, Jun 22, 2011 at 3:50 PM, Yann E. MORIN
>> <yann.morin.1998@anciens.enib.fr> wrote:
>> > Bryan, All,
>> >
>> > On Monday 20 June 2011 09:44:21 Bryan Hundven wrote:
>> >> # HG changeset patch
>> >> # User Bryan Hundven <bryanhundven@gmail.com>
>> >> # Date 1308555696 25200
>> >> # Node ID b25856d9153785d0f711206383480f0190aec363
>> >> # Parent Â2377be750e83defa6d764bcb8cf6dbaf098a19f6
>> >> glibc: Refactor startfiles/headers into do_libc
>> > Did you check that:
>> > Â- other archs were still OK?
>> > Â- both glibc and eglibc were still OK?
>>
>> I need to test more, but I was hoping by putting the patch out there,
>> I could get some more testing help?
>
> It's just that I am really overbooked these days.
> I'm entirely re-doing an entire room in the attic in the day from 9am to
> 7pm, and then I am simply too exhausted to do anything more than read my
> mails...
>
> Of course I'll help doing the tests! It will just have to wait until the
> end of next week (or maybe this WE, if all goes well and I can keep my
> attic-planning under control! :-] )

I totally understand 'personal life' vs. 'work life' vs. 'opensource
fun' conflicts ;)

>> >> +# vim: ts=4 sw=4 et ai syn=sh
>> > Spurious line. We do not have vim syntax settings in the source code.
>>
>> We could provide the combined emacs/vim syntax settings.
>
> Oh, do you mean the above works for emacs as well?

No, that would have been just vim. See next inline comment...

>> I use a lot of editors, and most of them either use vim or emacs style
>> 'mode lines'.
>> I prefer the modeline in the code, as I have other projects where they
>> like:
>> Â ts=2 sw=2 et
>>
>> and changing my .vimrc or .emacs for each project is a serious pain.
>
> Agreed! :-)
>
> OK. _IFF_ all the following is true:
> Â- we can have vim *and* emacs syntax on a single line,
> Â- that line can be either the first (or second for #! ), or the last line,
> Â- virtually all relevant editors use either vim or emacs markup,
>
> then please prepare such a patch with only the markup change.

Will do.

> My preference would be markup at the beginning of the file if possible,
> that way, we don't have to care about appending to an existing file.

I agree. I will formulate a patch for editor style 'modeline's for vim
and emacs.

> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | ÂYann E. MORIN Â| Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software ÂDesigner | \ / CAMPAIGN Â Â | Â___ Â Â Â Â Â Â Â |
> | +33 223 225 172 `------------.-------: ÂX ÂAGAINST Â Â Â| Â\e/ ÂThere is no Â|
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL  Â|  v  conspiracy. Â|
> '------------------------------^-------^------------------^--------------------'
>

-Bryan

--
For unsubscribe information see http://sourceware.org/lists.html#faq