Re: [PATCH] configure: support arbitrary versions via a shell script

["Yann E. MORIN" <yann dot morin dot 1998 at anciens dot enib dot fr>]

Michael, All,

On Monday 14 November 2011 21:37:15 Michael Hope wrote:
> That sounds good.  There's a minor bug in your version:  ./configure
> --help uses the version from .version instead of version.sh as
> do_help() is called before version.sh is updated.
> 
> Then again, it had a similar problem before the patch: ./configure
> --help would report crosstool-NG-hg instead of the full
> crosstool-NG-hg-revno-foo.

Indeed, the /issue/ was there previously as well.
So, it is not a regression! ;-)

> Let me know if it's important and I can make a patch,

I understand it could be confusing.
 - the easy way is to remove the version string from the help entry;
 - the proper way would be to move the version computation upward, but
   it needs ${sed} that is available only after the tests, which do not
   get run for --help.

So, we could just move the version calculations upward, print the pristine
version string in --help, and just mangle the string at the moment we need
it and can do it.

If the sight of the incorrect version string is absolutely untenable for
you, if your screen turns itself off so you don't get to see it, if you
lose your sanity at the mere thought of seeing the raw version, then by
all means, send a patch! ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq