Re: [PATCH 1/2] update mips-malta-linux-gnu sample

[Antony Pavlov <antonynpavlov at gmail dot com>]

On 22 November 2011 02:47, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Antony, Khem, All,
>
> On Monday 21 November 2011 23:38:32 Khem Raj wrote:
>> On Mon, Nov 21, 2011 at 11:49 AM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
>> > ---
>> > ?samples/mips-malta-linux-gnu/crosstool.config | ? 41 +++++++++++++-----------
>> > ?1 files changed, 22 insertions(+), 19 deletions(-)
>> >
>> > diff --git a/samples/mips-malta-linux-gnu/crosstool.config b/samples/mips-malta-linux-gnu/crosstool.config
>> > index 47cf010..35815b7 100644
>> > --- a/samples/mips-malta-linux-gnu/crosstool.config
>> > +++ b/samples/mips-malta-linux-gnu/crosstool.config
>> > @@ -1,7 +1,7 @@
>> > ?#
>> > ?# Automatically generated make config: don't edit
>> > -# crosstool-NG hg_default@2721_7b64746b0ab3 Configuration
>> > -# Sun Oct 16 17:29:33 2011
>> > +# crosstool-NG 1.13.1 Configuration
>> > +# Wed Nov 16 10:42:30 2011
>> > ?#
>> > ?CT_CONFIGURE_has_xzutils=y
>> > ?CT_CONFIGURE_has_cvs=y
>> > @@ -17,7 +17,11 @@ CT_MODULES=y
>> > ?#
>> > ?# CT_OBSOLETE is not set
>> > ?CT_EXPERIMENTAL=y
>> > -# CT_DEBUG_CT is not set
>> > +CT_DEBUG_CT=y
>> > +# CT_DEBUG_PAUSE_STEPS is not set
>> > +CT_DEBUG_CT_SAVE_STEPS=y
>> > +CT_DEBUG_CT_SAVE_STEPS_GZIP=y
>> > +# CT_NO_OVERIDE_LC_MESSAGES is not set
>> >
>> > ?#
>> > ?# Paths
>> > @@ -59,7 +63,7 @@ CT_PATCH_ORDER="bundled"
>> > ?#
>> > ?# Build behavior
>> > ?#
>> > -CT_PARALLEL_JOBS=0
>> > +CT_PARALLEL_JOBS=1
>> > ?CT_LOAD=0
>> > ?CT_USE_PIPES=y
>> > ?CT_EXTRA_FLAGS_FOR_HOST=""
>> > @@ -156,7 +160,7 @@ CT_USE_SYSROOT=y
>> > ?CT_SYSROOT_NAME="sysroot"
>> > ?CT_SYSROOT_DIR_PREFIX=""
>> > ?CT_WANTS_STATIC_LINK=y
>> > -# CT_STATIC_TOOLCHAIN is not set
>> > +CT_STATIC_TOOLCHAIN=y
>> > ?CT_TOOLCHAIN_PKGVERSION=""
>> > ?CT_TOOLCHAIN_BUGURL=""
>> >
>> > @@ -188,18 +192,18 @@ CT_BUILD_SUFFIX=""
>> > ?#
>> > ?CT_KERNEL_SUPPORTS_SHARED_LIBS=y
>> > ?CT_KERNEL="linux"
>> > -CT_KERNEL_VERSION="2.6.38.8"
>> > +CT_KERNEL_VERSION="3.0.4"
>> > ?# CT_KERNEL_bare_metal is not set
>> > ?CT_KERNEL_linux=y
>> > ?CT_KERNEL_bare_metal_AVAILABLE=y
>> > ?CT_KERNEL_linux_AVAILABLE=y
>> > -# CT_KERNEL_V_3_0_4 is not set
>> > +CT_KERNEL_V_3_0_4=y
>> > ?# CT_KERNEL_V_3_0_3 is not set
>> > ?# CT_KERNEL_V_3_0_2 is not set
>> > ?# CT_KERNEL_V_3_0_1 is not set
>> > ?# CT_KERNEL_V_3_0 is not set
>> > ?# CT_KERNEL_V_2_6_39_4 is not set
>> > -CT_KERNEL_V_2_6_38_8=y
>> > +# CT_KERNEL_V_2_6_38_8 is not set
>> > ?# CT_KERNEL_V_2_6_37_6 is not set
>> > ?# CT_KERNEL_V_2_6_36_4 is not set
>> > ?# CT_KERNEL_V_2_6_35_14 is not set
>> > @@ -250,7 +254,6 @@ CT_BINUTILS_FORCE_LD_BFD=y
>> > ?CT_BINUTILS_LINKER_LD=y
>> > ?CT_BINUTILS_LINKERS_LIST="ld"
>> > ?CT_BINUTILS_LINKER_DEFAULT="bfd"
>> > -# CT_BINUTILS_PLUGINS is not set
>> > ?CT_BINUTILS_EXTRA_CONFIG_ARRAY=""
>> > ?# CT_BINUTILS_FOR_TARGET is not set
>> >
>> > @@ -348,18 +351,19 @@ CT_CC_GCC_mips_synci=m
>> > ?# C-library
>> > ?#
>> > ?CT_LIBC="eglibc"
>> > -CT_LIBC_VERSION="2_13"
>> > +CT_LIBC_VERSION="2_14"
>> > ?CT_LIBC_eglibc=y
>> > ?# CT_LIBC_glibc is not set
>> > ?# CT_LIBC_uClibc is not set
>> > ?CT_LIBC_eglibc_AVAILABLE=y
>> > -# CT_LIBC_EGLIBC_V_2_14 is not set
>> > -CT_LIBC_EGLIBC_V_2_13=y
>> > +CT_LIBC_EGLIBC_V_2_14=y
>> > +# CT_LIBC_EGLIBC_V_2_13 is not set
>> > ?# CT_LIBC_EGLIBC_V_2_12 is not set
>> > ?# CT_LIBC_EGLIBC_V_2_11 is not set
>> > ?# CT_LIBC_EGLIBC_V_2_10 is not set
>> > ?# CT_LIBC_EGLIBC_V_2_9 is not set
>> > ?# CT_LIBC_EGLIBC_V_TRUNK is not set
>> > +CT_LIBC_EGLIBC_2_14_or_later=y
>> > ?CT_LIBC_EGLIBC_2_13_or_later=y
>> > ?CT_LIBC_EGLIBC_2_12_or_later=y
>> > ?CT_LIBC_EGLIBC_2_11_or_later=y
>> > @@ -427,7 +431,7 @@ CT_LIBC_ADDONS_LIST=""
>> > ?# CT_LIBC_GLIBC_KERNEL_VERSION_NONE is not set
>> > ?CT_LIBC_GLIBC_KERNEL_VERSION_AS_HEADERS=y
>> > ?# CT_LIBC_GLIBC_KERNEL_VERSION_CHOSEN is not set
>> > -CT_LIBC_GLIBC_MIN_KERNEL="2.6.38.8"
>> > +CT_LIBC_GLIBC_MIN_KERNEL="3.0.4"
>> >
>> > ?#
>> > ?# Debug facilities
>> > @@ -436,11 +440,10 @@ CT_LIBC_GLIBC_MIN_KERNEL="2.6.38.8"
>> > ?# CT_DEBUG_duma is not set
>> > ?CT_DEBUG_gdb=y
>> > ?CT_GDB_CROSS=y
>> > -# CT_GDB_CROSS_STATIC is not set
>> > -CT_GDB_CROSS_PYTHON=y
>> > +CT_GDB_CROSS_STATIC=y
>> > ?# CT_GDB_NATIVE is not set
>> > ?CT_GDB_GDBSERVER=y
>> > -# CT_GDB_GDBSERVER_STATIC is not set
>> > +CT_GDB_GDBSERVER_STATIC=y
>> >
>> > ?#
>> > ?# gdb version
>> > @@ -474,12 +477,12 @@ CT_GMP_V_5_0_1=y
>> > ?# CT_GMP_V_4_3_1 is not set
>> > ?# CT_GMP_V_4_3_0 is not set
>> > ?CT_GMP_VERSION="5.0.1"
>> > -# CT_MPFR_V_3_0_1 is not set
>> > -CT_MPFR_V_3_0_0=y
>> > +CT_MPFR_V_3_0_1=y
>> > +# CT_MPFR_V_3_0_0 is not set
>> > ?# CT_MPFR_V_2_4_2 is not set
>> > ?# CT_MPFR_V_2_4_1 is not set
>> > ?# CT_MPFR_V_2_4_0 is not set
>> > -CT_MPFR_VERSION="3.0.0"
>> > +CT_MPFR_VERSION="3.0.1"
>>
>>
>> why does this patch changes the defaults for this combo to generate
>> static toolchain ?
>> additionally it enables CT debug hooks which I think should be disabled too
>
> Khem, you are right; I noticed those after my initial reply.
>
> Antony, the debug hook CT_DEBUG_CT must be disabled in a sample.
>
> And while we are at it, any reason you force CT_PARALLEL_JOBS=1 ? This
> means parallel build is disabled, and will take a looong time to build.
> If the build breaks with // builds, it should be fixed.
>
> I consider the static toolchain to be an advanced setting, as not all
> systems have the necessary stuff installed by default. So it should not
> be set in a sample.

Yann, Khem!

Thans for your review. I shall fix the configuration and resend hg
patches in a few days.

-- 
Best regards,
? Antony Pavlov

--
For unsubscribe information see http://sourceware.org/lists.html#faq