This is the mail archive of the crossgcc@sourceware.org mailing list for the crossgcc project.
See the CrossGCC FAQ for lots more information.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Zhenqiang, All, On Tuesday 22 November 2011 12:53:42 Zhenqiang Chen wrote: > # HG changeset patch > # User Zhenqiang Chen <zhenqiang.chen@linaro.org> > # Date 1321523984 -28800 > # Node ID 640bdfd7d1efc1b91ad54304fefe6db77179ec65 > # Parent 986e1c75432aad60ae3239767198c653c08c01af > binutils/binutils: Add --disable-nls config when > option "Enable nls" is not selected. > > Reviewed-by: Michael Hope > Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org> > > diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh > --- a/scripts/build/binutils/binutils.sh > +++ b/scripts/build/binutils/binutils.sh > @@ -62,6 +62,8 @@ > [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}") > fi > > + [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls") Shoudn't we also force --enable-nls otherwise? if [ "${CT_TOOLCHAIN_ENABLE_NLS}" = "y" ]; then extra_config+=("--enable-nls") else extra_config+=("--disable-nls") fi Not sure what the default is (I guess enabled is, but better safe than sorry). Otherwise, good. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' -- For unsubscribe information see http://sourceware.org/lists.html#faq
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |