This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Re: [setup and gcc3] Revised patches - now with ChangeLog!
- From: Pavel Tsekov <ptsekov at gmx dot net>
- To: Max Bowsher <maxb at ukf dot net>
- Cc: Jason Tishler <jason at tishler dot net>, <cygwin-apps at cygwin dot com>
- Date: Tue, 5 Nov 2002 10:55:36 +0100
- Subject: Re: [setup and gcc3] Revised patches - now with ChangeLog!
On Mon, 4 Nov 2002, Max Bowsher wrote:
> >> Jason Tishler <jason@tishler.net> wrote:
> >>> What about the attached?
> >>> Note that I only tested setup.exe under Cygwin gcc 2.95.3-5 but I
> >>> also tried something similar under Linux gcc 3.x.
>
> > On Mon, Nov 04, 2002 at 08:05:08PM -0000, Max Bowsher wrote:
> >> Inlined:
> >> -LogSingleton::LogSingleton(){}
> >> +LogSingleton::LogSingleton() : ostream(rdbuf()){}
> >>
> >> Certainly looks less hackish than mine.
But doesn't make any sense. Why call rdbuf() when it just returns the
internal streambuf pointer i.e. the one which you want to set.
IMO, it is good to use ostream (NULL) here and in each of the LogSingleton
heirs' constructors to do rdbuf (new somestreambuf).