This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [ITP] rebase

From: Jason Tishler <jason at tishler dot net>
To: Ralf Habacker <Ralf dot Habacker at freenet dot de>
Cc: Max Bowsher <maxb at ukf dot net>, cygwin-apps at cygwin dot com
Date: Tue, 11 Feb 2003 08:43:34 -0500
Subject: Re: [ITP] rebase
References: <20030210131625.GE2408@tishler.net><005c01c2d13a$671fc980$d8a907d5@BRAMSCHE>

Ralf,

On Mon, Feb 10, 2003 at 08:27:08PM +0100, Ralf Habacker wrote:
> > I can reproduce it now.  I will debug and try to fix it myself.  If
> > I'm unsuccessful, then I will ask Ralf for help.
> >
> Jason, your rebase depends on the ms imagehelp library, isn't it.

Not anymore:

    $ rebase -V
    rebase version 2.1
    Copyright (c) 2001, 2002, 2003 Ralf Habacker and Jason Tishler

We are partners in crime now. :,)

The attached patch solves the SEGV problem.

Your guard:

    (char *)relocp < (char *)relocs + size

wasn't tight enough.

My version:

    (char *)&relocp->SizeOfBlock < (char *)relocs + size

seems to be.

Did I break anything with this patch?

Thanks,
Jason

-- 
PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers
Fingerprint: 7A73 1405 7F2B E669 C19D  8784 1AFD E4CC ECF4 8EF6

Attachment: sections.cc.diff
Description: Text document

Follow-Ups:
- RE: [ITP] rebase
  - From: Ralf Habacker

References:
- Re: [ITP] rebase
  - From: Jason Tishler
- RE: [ITP] rebase
  - From: Ralf Habacker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]