This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix iterator bug in

On 14 Mar 2003, Robert Collins wrote:

> On Fri, 2003-03-14 at 07:47, Igor Pechtchanski wrote:
> > I noticed there is a bug in an iterator in that causes "All" to
> > be printed twice in the list of categories in setup.log.full.  The
> > attached patch fixes that.  Note that, like the original, the patch will
> > not work if a package is not in any category (but that shouldn't happen
> > anyway, right?).
> >       Igor
> > ==============================================================================
> > 2003-03-13  Igor Pechtchanski <pechtcha at cs dot nyu dot edu>
> >
> >       * (ChooserPage::OnNext): Fix iterator bug.
> Nice catch. Wouldn't
>             = pkg.categories.begin ();
> ->          String all_categories = *(i++);
> Be an easier fix?

It's shorter, but I dislike the use of increment operators outside of
loops.  Leads to obscure errors.  Personal preference, y'know... :-)
But it's your preference that counts, so feel free to tweak it.
      |\      _,,,---,,_		pechtcha at cs dot nyu dot edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor at watson dot ibm dot com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk!
  -- /usr/games/fortune

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]