This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Standardize previous ChangeLog entries?


Igor Pechtchanski wrote:
> On Tue, 25 Mar 2003, Max Bowsher wrote:
>
>> Igor Pechtchanski wrote:
>>> On Tue, 25 Mar 2003, Max Bowsher wrote:
>>>
>>>> Igor Pechtchanski wrote:
>>>>> On Tue, 25 Mar 2003, Max Bowsher wrote:
>>>>>
>>>>>> OK to add the correct double-space between NAME and <EMAIL> in the
>>>>>> ChangeLog lines "DATE  NAME  <EMAIL>"?
>>>>>>
>>>>>> There are 24 single-spaced lines compared with 283 double-spaced
>>>>>> lines. Max.
>>>>>
>>>>> FWIW, I count 125 single-spaced lines vs. 294 double-spaced lines...
>>>>> I used the following patterns in vim:
>>>>>
>>>>> /^[^ \t].*[^ ] </ for single-spaced, and
>>>>> /^[^ \t].*[^ ]  </ for double-spaced.
>>>>>
>>>>> This also brings up an interesting question of what the proper date
>>>>> format is.  Most (320) dates are in the YYYY-MM-DD format, but some
>>>>> (99) are in the "Dow Mon DD HH:MM:SS YYYY" format, and some of those
>>>>> have 2 spaces before YYYY.  Weird.
>>>>
>>>> Hmm. I hadn't noticed the old date format, so my regexps didn't match
>>>> any of those lines.
>>>> However, your regexps match some lines incorrectly - for example:
>>>>         * archive_tar_file.cc: Include <algorithm>.
>>>>         * inilex.l: Recognise Build-Depends-Indep, [,], >, < and remove
>>>>         (filedef): Create == and < operators for STL use.
>>>> Max.
>>>
>>> They don't for me, but this could be because I have vim set to
>>> 'nocompatible' or something.  The "\t" matches a Tab.  If you substitute
>>> that by a literal Tab character, these should work even in 'compatible'
>>> mode.
>>
>> I was using egrep.
>> Max.
>
> Ok.  For the record, in vim, 'cpoptions' have to be missing 'l' for '\t'
> to work in patterns.
>
> However, I noticed something else.  The dates in the ChangeLog are
> supposed to reflect the commit date.

This is my personal preference, but is it clearly stated anywhere?

> Looks like some were left unchanged
> in later commits...  AFAIU, this falls within the responsibility of the
> person who does the commit.  Do they need to be fixed?

There is always "cvs log" if someone wants truly accurate dates.

Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]