This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Bigger Chooser Episode 4: The Nobox Strikes Back


On Sat, 2003-04-05 at 19:41, Gary R. Van Sickle wrote:
> Adds a "note_nobox()" variant of the "note()" function which doesn't pop up a
> message box.  Used in an upcoming patch to eliminate the final, separate,
> "Install Complete" message box in favor of a more-traditional "Finished" page.

This duplicates the mbox logic. Please extract the common logic to a
utility class (preferred) or static function (will accept this).

Cheers,
Rob

P.S. Thanks for breaking this up, it makes it a LOT easier to review.

-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]