This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
RE: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP
- From: "Gary R. Van Sickle" <g dot r dot vansickle at worldnet dot att dot net>
- To: "Cygwin-Apps" <cygwin-apps at sources dot redhat dot com>
- Date: Sat, 5 Apr 2003 09:46:27 -0600
- Subject: RE: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP
> Robert Collins wrote:
> > On Sat, 2003-04-05 at 19:23, Gary R. Van Sickle wrote:
> >> 2003-04-05 Gary R. Van Sickle <g dot r dot vansickle at worldnet dot att dot net>
> >>
> >> * RECTPP.h: New file.
> >
> > Much better. A few remaining nits.
> >
> > a) The class name, as discussed before.
> > b) RECTCC_H__F4098557_9A48_446d_AF28_2BE45D29F68D__INCLUDED_
> > Uhm, thats plain ugly.
It's a GUID, it's supposed to by ugly. Guaranteed to be unique, not going to
collide with anything ever. That's how MS's "AppWizard" does it, and it seems
like a good idea to me. Please Rob, if you're going to pick nits, pick on
something that could possibly matter. For me? Please?
> > c) (optional) It might be an idea to mention that no virtual methods are
> > permitted in the class, and that no additional parents are allowed, as
> > either would break binary interchangeability with the MS RECT class.
>
> Given that it is derived from RECT, I think RECTPP is a good name.
I concur.
--
Gary R. Van Sickle
Brewer. Patriot.