This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Allow logging of {pre,post}remove scripts


On Tue, 2003-04-01 at 11:28, Igor Pechtchanski wrote:


> I agree with the sentiment above.  I also think that moving all the static
> functionality into the Script class is the way to go.  However, as spare
> time is sparse these days, I probably won't get to it for a bit.  In the
> meantime, the attached patch provides logging for preremove script in a
> minimal way.

Well, I've taken a slightly less minimal way. I've removed the to_log
parameter, as I indicated was my preference :}.

I've left the to_log BOOL in place, for now.

Let me be clear about this though: If you don't provide a patch to
parameterise the behaviour (or to make use of the non logged
functionality) I will remove the conditionals eventually.

I don't want to have the code more complex than needed, just for some
'eventual' purpose.

Rob


-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]