This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Re: a2ps download site
- From: Igor Pechtchanski <pechtcha at cs dot nyu dot edu>
- To: Max Bowsher <maxb at ukf dot net>
- Cc: cygwin-apps at cygwin dot com, <David_Hudson at capgroup dot com>
- Date: Tue, 15 Apr 2003 17:07:32 -0400 (EDT)
- Subject: Re: a2ps download site
- Reply-to: cygwin-apps at cygwin dot com
On Tue, 15 Apr 2003, Max Bowsher wrote:
> Igor Pechtchanski wrote:
> > David,
> >
> > Looks much better now.
> > A few more nits:
> > - The patch still has CRLF line endings.
> > - The .tar.gz file extracted from the source archive has executable bits
> set.
>
> This hasn't been rigourously checked for in the past.
> Does it matter? If so, someone needs to patch the "Contributing" webpage.
It probably doesn't matter, which is why I called them "nits" rather than
"problems". I'm "nitpicking" :-D
> > - Why does the "all" step in the script perform the "spkg" and "pkg"
> > steps? They are not needed for the build. Neither is "finish", for that
> > matter. (That may be an artifact of the build script, if so, ignore
> this).
>
> That's from the build script, so leave it as is.
>
> If you think about it, "all" from the perspective of a packager does
> logically include spkg, pkg and finish.
Yes, but then the build instructions in the README should not say
"./a2ps-4.12-1.sh all", but rather "./a2ps-4.12-1.sh prep &&
./a2ps-4.12-1.sh conf && ./a2ps-4.12-1.sh build && ./a2ps-4.12-1.sh
install".
> > - Is there a particular reason why the build is performed in-place, rather
> > than in a .build directory (which is created, BTW)?
Is this one usually checked for? Does it matter?
Igor
> > Other than that, all seems to be ok. The build seems to work. As I said,
> > I haven't tested the binaries, but I assume you did and they work. The
> > patch now contains only the Cygwin-specific README and the setup.hint, so
> > it's basically an OOTB build, anyway.
> >
> > So, once the package is deemed ready, we wait until you accumulate the
> > necessary votes (I think you have already), and someone with access will
> > upload your package to the mirror. It might be a good idea for you to
> > include the URLs of 3 files in the follow-up message: the binary and
> > source package tarballs and setup.hint, so that they're all in one place.
>
> Yes, it helps.
> Max.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha at cs dot nyu dot edu
ZZZzz /,`.-'`' -. ;-;;,_ igor at watson dot ibm dot com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Knowledge is an unending adventure at the edge of uncertainty.
-- Leto II