This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Setup window.{cc,h}


Approved on one condition - please remove the reference to folk in Hell.
I'm not christian, but that doesn't seem at all appropriate.

A small suggestion (doesn't prevent it being commited) - a helper fn to
return an already casted value might reduce the number of casts needed.

Cheers,
Rob

On Tue, 2003-06-03 at 13:36, Gary R. Van Sickle wrote:
> 2003-06-02  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
> 
> 	* window.h (SETUP_WINDOW_H): Rename multi-include guard.
> 	(Copyright): Update.
> 	(RECTWrapper): New forward declaration.
> 	(Window::Create): Move.
> 	(Window::MoveWindow): New overload declaration.
> 	* window.cc: (RECTWrapper.h) Include.
> 	(Copyright): Update.
> 	(Window::FirstWindowProcReflector): Use reinterpret_cast<> instead
> 	of C-style casts.
> 	(Window::MoveWindow): New overload.
-- 
GPG key available at: <http://members.aardvark.net.au/lifeless/keys.txt>.

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]